Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aurora 2-gang dimmer #256

Merged
merged 8 commits into from
Mar 6, 2021
Merged

Aurora 2-gang dimmer #256

merged 8 commits into from
Mar 6, 2021

Conversation

bens0n
Copy link
Contributor

@bens0n bens0n commented Mar 3, 2021

ZHA implementation of Aurora 2-gang dimmer switch. See zigpy/zha-device-handlers#795 for details on ZHA/zigpy integration of the switch itself, though the events hooked into here are independent of the implementation details. Unsure where to put example advanced configuration - as nobody will want to use both gangs to control the same light, this controller will always require two instances as per example.

@xaviml
Copy link
Owner

xaviml commented Mar 6, 2021

Hi @bens0n,

Thank you for your contribution :) I added/changed the following:

  • Resize the image
  • Change the delay to 350 (which is the default)
  • Change .yaml to .yml
  • Add tests for the device
  • Refactor slightly the implementation for get_zha_action

The rest was okay, so I will merge this now.

Regards,
Xavi M.

@xaviml xaviml merged commit 8a5df17 into xaviml:dev Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants