Added new actions #472
Merged
Added new actions #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
don't merge this yet. performing some tests. |
|
Tested! Everything seems to work as expected. |
|
Hi @sabaatworld, Thank you for the PR. It looks good to me, but I would like to add some integration tests for this feature. I will add them in your branch and merge this away! :) Regards, |
xaviml
added a commit
to sabaatworld/controllerx
that referenced
this pull request
Apr 30, 2022
…ed action related to xaviml#472
xaviml
added a commit
that referenced
this pull request
Apr 30, 2022
…n_max_color_temp, on_max_min_color_temp
…ed action related to xaviml#472
|
Hi @sabaatworld, I added some integration tests and refactor the code a bit to be more clear. I have also considered the light state for an edge case it was missed. Regards, |
|
I like your version more. It's much cleaner! Thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is for adding the following actions: on_min_max_brightness, on_max_min_brightness, on_min_max_color_temp, on_max_min_color_temp.
These are something that I needed and thought it would be best to implement in controllerx. This should not impact any existing setups. Please check out the docs to see the intended purpose. I was able to test out the actions with E1810 IKEA controller (Z2M) but could not test out generating the docs. There shouldn't be any errors though.