Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore bmc interfaces defined in the nics table #4539

Merged
merged 1 commit into from
Dec 20, 2017
Merged

ignore bmc interfaces defined in the nics table #4539

merged 1 commit into from
Dec 20, 2017

Conversation

kcgthb
Copy link
Member

@kcgthb kcgthb commented Dec 15, 2017

workaround for #4538

If BMC interfaces are defined in the nics table, just ignore them, so confignetwork doesn't exit with an error.

BMC interfaces may need to be defined in nics to generate proper DNS records, but confignetwork can't actually configure them. Their configuration is handled in bmcsetup.

@kcgthb kcgthb mentioned this pull request Dec 15, 2017
Closed
@xcatbot
Copy link

xcatbot commented Dec 15, 2017 •
edited
Loading

CI CHECK RESULT : > PR FORMAT CORRECT> BUILD SUCCESSFUL > INSTALL XCAT SUCCESSFUL> CODE SYNTAX CORRECT> FAST REGRESSION TEST Successful: Totalcase 215 Pass 215 failed 0

@bybai bybai self-assigned this Dec 18, 2017
@bybai bybai added this to the 2.13.10 milestone Dec 20, 2017
@bybai bybai added the sprint1 label Dec 20, 2017
@bybai
Copy link
Contributor

bybai commented Dec 20, 2017

I am ok to merge it. Thanks.

@bybai bybai merged commit 1d916bf into xcat2:master Dec 20, 2017
@kcgthb kcgthb deleted the confignetwork_ignorebmc branch January 26, 2018 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bybai bybai

Labels
sprint1
Projects
None yet
Milestone
2.13.10
Development

Successfully merging this pull request may close these issues.
3 participants
@kcgthb @xcatbot @bybai