Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

powersupplyredundancy enhancements #4720

Merged

Conversation

gurevichmark
Copy link
Contributor

This pull request implements #4715

  • New type of defined attribute is introduced "action_attribute". This type of attribute is set using /action/setValue and queried using /action/getValue

  • If user supplies invalid value for the attribute on the command line, list of valid values is listed.

  • If user somehow manages to get an unsupported value into an attribute, a warning is given when such attribute is queried and a list of valid values is listed.

  • Error message is displayed if the target node of the command does not support the API call (back level of FW).

@xcatbot
Copy link

xcatbot commented Jan 24, 2018

CI CHECK RESULT : > PR FORMAT CORRECT> BUILD SUCCESSFUL > INSTALL XCAT SUCCESSFUL> CODE SYNTAX CORRECT> FAST REGRESSION TEST Successful: Totalcase 215 Pass 215 failed 0

@gurevichmark gurevichmark force-pushed the openbmc_rspconfig_powersupplyredundancy2 branch 2 times, most recently from c88e4e6 to 622729c Compare January 24, 2018 21:42
@gurevichmark gurevichmark force-pushed the openbmc_rspconfig_powersupplyredundancy2 branch from 622729c to 691669b Compare January 24, 2018 21:48
Copy link
Member

@whowutwut whowutwut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the changes

@whowutwut whowutwut merged commit 44c6c69 into xcat2:master Jan 25, 2018
@gurevichmark gurevichmark deleted the openbmc_rspconfig_powersupplyredundancy2 branch January 25, 2018 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants