Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in custom color maps related to colors defined in RGB #1059

Merged
merged 1 commit into from
Aug 13, 2024
Merged

Fix bug in custom color maps related to colors defined in RGB #1059

merged 1 commit into from
Aug 13, 2024

Conversation

konstntokas
Copy link
Contributor

@konstntokas konstntokas commented Aug 13, 2024 •
edited
Loading

Closes #1046

CHANGES.md will not be updated, as it is already updated in #1055.

Checklist:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/source/*
  • Changes documented in CHANGES.md
  • GitHub CI passes
  • AppVeyor CI passes
  • Test coverage remains or increases (target 100%)

@konstntokas konstntokas mentioned this pull request Aug 13, 2024
Closed
@konstntokas konstntokas changed the title bug fix custom color maps Fix bug in custom color maps related to colors defined in RGB Aug 13, 2024
ruchimotwaniBC
ruchimotwaniBC approved these changes Aug 13, 2024
View reviewed changes
Copy link
Contributor

@ruchimotwaniBC ruchimotwaniBC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried few combinations and works now!!

@konstntokas
Copy link
Contributor Author

Tried few combinations and works now!!

Great! Thank you!

@konstntokas konstntokas merged commit cc5fd92 into main Aug 13, 2024
4 checks passed
@konstntokas konstntokas deleted the konstntokas-1046-fug_fix_rgb_code_custom_cmaps branch August 13, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchimotwaniBC ruchimotwaniBC ruchimotwaniBC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Configure custom color maps in xcube server
2 participants
@konstntokas @ruchimotwaniBC