Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct get last version task #97

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pegail
Copy link

@pegail pegail commented Jun 21, 2018

Correct GetLastVersion task not returning good package when there are strings and numbers in the package name

Copy link
Contributor

@jdewinne jdewinne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this changes the functionality. Original the idea is to return the latest version as ordered by XLD.
This implementation uses the ordering based on the deployment package name.

@pegail
Copy link
Author

pegail commented Jun 27, 2018

In this case this is even not working correctly, I found a case where the original GetLastVersion task was not returning the latest version as ordered by XLD, but another package that was in the middle of my packages list in XLD.
The correction I've done is returning the most recent package, based on the version number containing in the package names. This is working and more relevant I think.

@ftravaglia
Copy link

Hello,

@pegail , can you tell me if this PR were accepted or not please .

Thanks

@pegail
Copy link
Author

pegail commented Sep 24, 2018

Hello,

@pegail , can you tell me if this PR were accepted or not please .

Thanks

Hello Fabien,
Unfortunately this PR has not yet been accepted, I have no answer since my last comment.

@ftravaglia
Copy link

Thank you for this quick response :) . I've resume the work of Clement and i don't use the plugin for list the version (i use the rest API directly) . You can refuse this PR i you want, i don't correct the code of Clement.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants