-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct get last version task #97
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this changes the functionality. Original the idea is to return the latest version as ordered by XLD.
This implementation uses the ordering based on the deployment package name.
In this case this is even not working correctly, I found a case where the original GetLastVersion task was not returning the latest version as ordered by XLD, but another package that was in the middle of my packages list in XLD. |
Hello, @pegail , can you tell me if this PR were accepted or not please . Thanks |
Hello Fabien, |
Thank you for this quick response :) . I've resume the work of Clement and i don't use the plugin for list the version (i use the rest API directly) . You can refuse this PR i you want, i don't correct the code of Clement. |
Correct GetLastVersion task not returning good package when there are strings and numbers in the package name