Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2889 v2 #34

Merged
merged 38 commits into from
May 31, 2023
Merged

2889 v2 #34

merged 38 commits into from
May 31, 2023

Conversation

leonardhyu
Copy link
Contributor

No description provided.

fpfeng and others added 30 commits January 20, 2023 12:22
keep the same value as valkyrie using "custom"

Signed-off-by: fpfeng <fpfeng@users.noreply.github.com>
fix: #9 converter breaks with custom port rate
refactor: adjust 2889 folder structure
Fix: 2889 create port pair error
@leonardhyu
Copy link
Contributor Author

@ArtemConstantinov it seems GitHub doesn't allow me to create PR from 2544-v2 to dev or from 3918-v2 to dev. Could you guys help on merging them to dev ? thanks.

@leonardhyu leonardhyu merged commit 3cc9f0b into dev May 31, 2023
@fpfeng fpfeng deleted the 2889-v2 branch June 2, 2023 02:46
@leonardhyu leonardhyu added the feature New feature or request label Jun 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants