Create a separate project for QuerydslPredicateResolver and associated machinery #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vierbergenlars
force-pushed
the
separate-querydsl-predicate-resolver
branch
2 times, most recently
from
b95adfd
to
230a6dc
Compare
vierbergenlars
force-pushed
the
separate-querydsl-predicate-resolver
branch
2 times, most recently
from
81c7ad2
to
e69d191
Compare
vierbergenlars
force-pushed
the
separate-querydsl-predicate-resolver
branch
from
e69d191
to
03160d5
Compare
tgeens
approved these changes
Aug 29, 2023
.../contentgrid/thunx/spring/data/querydsl/predicate/injector/resolver/OperationPredicates.java
Outdated
Show resolved
Hide resolved
…dicates This is a focussed, reusable piece of code that is not tightly bound to the Thunx ABAC system, and that is reusable for other purposes without having to use all of thunx.
…sing a single item Some filters should only be applied when filtering a collection, not when accessing a single item
vierbergenlars
force-pushed
the
separate-querydsl-predicate-resolver
branch
from
44e667f
to
df0ed6e
Compare
vierbergenlars
force-pushed
the
separate-querydsl-predicate-resolver
branch
from
df0ed6e
to
d698b0b
Compare
tgeens
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split off QuerydslPredicateResolver that allows supplying arbitrary QueryDSL predicates.
It is a focussed, reusable piece of code that is not tightly bound to Thunx ABAC and can be reused without having to import all of thunx.
Also add the predicate injecting RootResourceInformationHandlerMethodArgumentResolver and autoconfiguration.
The returnvalue of QuerydslPredicateResolver has also changed to split up between predicates for listing/reading/creating/updating and deleting.
That is mainly for Thunx integration, so we can later provide separate predicates and give a better message than 404 if the user is allowed to read an item, but just not allowed to edit/delete it.