.addValidator after .default removes default setting

[PvdBerg1998]

The following code

private val x by parser.storing(
		"-x",
		help = "",
		transform = String::toInt
).addValidator {
	// Validate here
}.default(0)

receives the default value of 0 and gets labeled as optional, while

private val x by parser.storing(
		"-x",
		help = "",
		transform = String::toInt
).default(0).addValidator {
	// Validate here
}

does not, and gets labeled as required parameter.

[PvdBerg1998]

Note that the first snippet produces a NPE when the optional property gets left out.

[xenomachina]

Thanks for reporting this issue. I'm working on a fix and should have something ready shortly.

[xenomachina]

Ok, I have released a fix for this. The second test case, .default(...).addValidator(...) now works correctly.

The first test case, .addValidator(...).default(...), will now throw an IllegalStateException, as this is a potentially unsafe operation, since .default can actually change the type (for example, making it nullable, or by making it a supertype), and then there's no way to pass the default value to the validator.

I'm debating whether to make it possible to add a validator before a default, and simply have the validator not called when the default is used. This is potentially surprising behavior.

[PvdBerg1998]

Nice, thanks for the support.