Using TCK Tested JDK builds & fixed versions of OpenJDK #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AdoptOpenJDK has been discontinued since July 2021. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK. Also added fixed (major) version releases for LTS JDKs.
xerial
reviewed
Sep 11, 2021
xerial
reviewed
Sep 11, 2021
|
Thanks for the information. I learned a lot about recent changes around AdoptOpenJDK. Using the latest head versions of JDK is not my concern (e.g., 11.0.3), so just switching to Let me try |
|
It seems temurin build has no problem. I'll go with it. Thanks |
|
You're welcome. Glad to have helped contribute. :-) |
Willena
added a commit
to Willena/sqlite-jdbc-crypt
that referenced
this pull request
Jan 15, 2022
* Tried updating github actions file * Add CI tests for aarch64 and armv7 (xerial#658) * multiarch test * cleanup before PR * revert file * fix action version * update CI badge on README.md (xerial#661) * Switch to Temurin JDK builds as AdoptJDK has been discontinued (xerial#660) * Update Eclipse settings to use Java 8 (xerial#664) * Fix file descriptor (handle) leak when opening database fails (xerial#665) xerial#431 * Add native libs for Android arm64, x86, x86_64 via dockcross (xerial#662) * cleanup OSInfo.java with IDE suggestions * add native build for android aarch64, x86 and x86_64 * add android native builds * change native lib resolution for Android * refactor for tests in OSInfo.java * add missing test scope for mockito dep * add new targets to native-all * Use more specific types instead of String when fetching JDBC3ResultSet.getBigDecimal (xerial#666) * detect musl by checking /proc/self/map_files (xerial#675) * detect musl by checking /proc/self/map_files * spotless:apply * Update src/main/java/org/sqlite/util/OSInfo.java Co-authored-by: Roman Parshikov <promansew@gmail.com> * spotless:apply Co-authored-by: Roman Parshikov <promansew@gmail.com> * let's start by testsing ;) * Let's try building natives * Add missing packages * Another try * Maximise build space :) * in fact might not be needed. Just removing dirs ! * Removed freebsd32 freebsd64 freebsd-arm64 temporarily * Add missing Linux-aarch64 def * Updated compile option for Android x86 and Android x64 * Added Package target and build binary zip ! * Now download specific SQLite3MC versions * Updated existing "quick" tests * Revert removing dependency in pom.xml * Fixing build with theses changes ? * Revert version upgrades in pom.xml * Fixed CI errors (windows build) * Small fix for strip * Moved to curl as it works best * Removed outdated version of OSInfo.class; Updated Makefile.common to rebuild it if missing. * Applied spotless fixes * Upgrade SQLite3MC to 1.3.4 - 3.36.0 * Configured credentials for auto-deploy Co-authored-by: Gauthier <gotson@users.noreply.github.com> Co-authored-by: Carl Dea <carl.dea@gmail.com> Co-authored-by: Taro L. Saito <leo@xerial.org> Co-authored-by: Andy-2639 <Andy-2639@users.noreply.github.com> Co-authored-by: Andrey.Tarashevskiy <fantocci@gmail.com> Co-authored-by: Roman Parshikov <promansew@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AdoptOpenJDK has been discontinued since July 2021. When using Zulu you get all the latest updated (TCK Tested) builds for all versions of OpenJDK. Also added fixed (major) versions to the list of JDKs to build. This is good practice when customers or vendors are at fixed versions in production and using the latest can / has broken. If the fixed version is green (passed) and the latest is red (test failed) that means it isn’t your code that broke, but the latest build was the cause of the issue.
As AdoptOpenJDK -> Adoptium -> Eclipse Foundation has suggested Temurin builds (which also are nice TCK tested builds) they do not support every version of OpenJDK such as many non-LTS versions and fixed version prior to july/aug 2021.