update OSInfo.java

[ChanthMiao]

• add ppc64el/ppc64le mapping

• recompile OSInfo.class with JDK 1.8

• delete old 'lib/org/sqlite/OSInfo.class'

[gotson]

The class files should not even be here, I think they are not used and should be deleted completely.

[ChanthMiao]

The class files should not even be here, I think they are not used and should be deleted completely.

sqlite-jdbc/Makefile.common

Lines 20 to 24 in ada2b14

	ifndef OS_NAME
	OS_NAME := $(shell $(JAVA) -cp lib $(OSINFO_CLASS) --os)
	endif
	ifndef OS_ARCH
	OS_ARCH := $(shell $(JAVA) -cp lib $(OSINFO_CLASS) --arch)

It seems that the class files are referenced here.

[gotson]

Looks like it's used only when OS_NAME and OS_ARCH are not passed, so probably when using make native.

IMHO we should compile osinfo if needed when those variables are not needed, instead of committing them to source control.

[ChanthMiao]

You are right. We should not commit class files to git repo

[ChanthMiao]

@gotson I just made a new PR #697, which deleted precompiled OSInfo.class safely.

[gotson]

@ChanthMiao looking at the existing code in master, it should work fine.

The only problem is that that class files must have been committed by error.

I would suggest a single PR that deletes the existing class, and adds a .gitignore entry to avoid committing again in the future.

Separating your PR about ppc64le in another PR would also make the PR clearer and easier to merge IMHO.

[ChanthMiao]

@gotson It was not commited by error. The OSInfo.class was commit by f09fb1e

Then it Integrated by the other commit 6d3bfb7

[ChanthMiao]

@ChanthMiao looking at the existing code in master, it should work fine.

The only problem is that that class files must have been committed by error.

I would suggest a single PR that deletes the existing class, and adds a .gitignore entry to avoid committing again in the future.

Separating your PR about ppc64le in another PR would also make the PR clearer and easier to merge IMHO.

The new PR, which deletes the existing class is here #698.

If it merged, I would make the other one to add ppc64le mapping

[gotson]

@ChanthMiao i will merge #715 soon that will handle OSInfo on the fly compilation.

Can you cleanup this PR to keep only the ppc64el/ppc64le mapping ? This should help to close #450

[ChanthMiao]

Can you cleanup this PR to keep only the ppc64el/ppc64le mapping ? This should help to close #450

I may do it this weekend.

[ChanthMiao]

@gotson Done!