Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add handling for ESM typescript & node 18 #1162

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Add handling for ESM typescript & node 18 #1162

merged 4 commits into from
Jan 13, 2023

Conversation

phawxby
Copy link
Contributor

@phawxby phawxby commented Jan 12, 2023 •
edited by github-actions bot
Loading

Version

Published prerelease version: @xerox/cli@2.0.3-next.0
@xerox/commitlint-config@3.1.4-next.0
@xerox/eslint-config@5.0.3-next.0
@xerox/semantic-release-config@4.0.3-next.0
@xerox/stylelint-config@3.0.3-next.0

Changelog

Fix

  • @xerox/eslint-config

Dependencies

Authors: 3

@phawxby phawxby requested a review from AndrewLeedham January 12, 2023 15:39
@phawxby phawxby enabled auto-merge (squash) January 12, 2023 15:39
@phawxby phawxby changed the title Add handling for ESM typescript Add handling for ESM typescript & node 18 Jan 12, 2023
AndrewLeedham
AndrewLeedham approved these changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@AndrewLeedham AndrewLeedham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI the pending 18.x test was because I was trying to move to just 16.x and 18.x and pnpm in #1161 but I hit a wall with CI giving an error local doesn't. So I've reverted the required action changed.

@phawxby phawxby merged commit db1f2c2 into next Jan 13, 2023
@phawxby phawxby deleted the PH-cjs branch January 13, 2023 00:58
@github-actions github-actions bot mentioned this pull request Jan 13, 2023
Merged
@github-actions
Copy link

🚀 PR was released in @xerox/cli@2.0.3, @xerox/eslint-config@5.0.3, @xerox/semantic-release-config@4.0.3, @xerox/stylelint-config@3.0.3 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AndrewLeedham AndrewLeedham AndrewLeedham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phawxby @AndrewLeedham