Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove build step and go full ESM #994

Merged
merged 4 commits into from
Jan 26, 2022
Merged

Remove build step and go full ESM #994

merged 4 commits into from
Jan 26, 2022

Conversation

AndrewLeedham
Copy link
Contributor

@AndrewLeedham AndrewLeedham commented Jan 24, 2022 •
edited
Loading

  • There were no actual types in the CLI implementation, so I removed the build process and just when with JS straight in the bin folder, it is still type checked as JS.
  • Added "type": "module" to the cli package.json and used full ESM features like top level await etc.

@AndrewLeedham AndrewLeedham added needs review change: feature Adds a new feature or improves on an existing one labels Jan 24, 2022
@AndrewLeedham AndrewLeedham marked this pull request as ready for review January 24, 2022 16:15
@AndrewLeedham AndrewLeedham requested a review from phawxby January 24, 2022 16:16
@AndrewLeedham AndrewLeedham merged commit 6786390 into next Jan 26, 2022
@AndrewLeedham AndrewLeedham deleted the AL-cli-full-esm branch January 26, 2022 12:26
@github-actions
Copy link

github-actions bot commented Feb 7, 2022

🚀 PR was released in @xerox/browserslist-config@2.1.0-next.0, @xerox/cli@1.1.1-next.0, @xerox/commitlint-config@3.1.1-next.0, @xerox/eslint-config@4.1.1-next.0, @xerox/prettier-config@3.1.0-next.0, @xerox/semantic-release-config@3.1.1-next.0, @xerox/stylelint-config@2.1.1-next.0 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phawxby phawxby phawxby approved these changes

Assignees
No one assigned
Labels
change: feature Adds a new feature or improves on an existing one
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndrewLeedham @phawxby