-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable WP emojis polyfill #285
Comments
Why? |
👍 on that. Anyone recall if any of our customers did use that? I would do it without the plugin if we decide on that. I could actually work on that if we decide to disable it. |
Thanks, @marcinkrzeminski. I'm wondering if using the plugin wouldn't be better because if we want to do it properly we will have copy the code from the plugin anyway. Then we will have to maintain that code while with plugin it's up to its author https://wordpress.org/support/plugin/disable-emojis and you can easily update the plugin to fix issues. Also deactivating plugin if someone needs that WP emojis polyfill is more flexible than updating the theme code. |
Yeah there are always some up and downsides of each solution ;). I just like to keep the number of plugin as low as possible, my personal preference. The downside of going with plugin is that the customer could always disable the plugin ;). I guess we need to decide what's more important for us. Despite the solution we choose I'll be willing to implement it anyway. If we go for a plugin solution you think we should give the developer an option to install this plugin or not like we have for Gravity and other plugins. |
I also prefer keeping number of plugins as low as possible. But if we will have to copy the code from the plugin to the chisel it does not make sense. What if plugin gets updated? You will update the code in old chisel project? WP will handle that automatically if it will be a plugin. |
I'm OK with that ;). What about the others? |
For me it's ok too :) We can later document which plugins are installed by default (Timber, obviously, and this one) and explain why. |
👍 When we have a decision you can assign it to me and I'll work on it when heaving some time to spare ;) |
@marcinkrzeminski thanks, I've invited you to collaborate on the project so I can assign this to you then :) |
Resolve xfiveco#285 Fix the issues reported by @jakub300
Resolve xfiveco#285
In default WP installation Emojis JS is loaded, we could disable it either by installing https://wordpress.org/plugins/disable-emojis/ plugin or by copying code from it to a new Chisel class. Thoughts?
The text was updated successfully, but these errors were encountered: