Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add audio filter #29

Merged
merged 3 commits into from
Apr 16, 2019
Merged

add audio filter #29

merged 3 commits into from
Apr 16, 2019

Conversation

timotto
Copy link
Contributor

@timotto timotto commented Mar 16, 2019

This pull request adds the capability to specify audio filters using SetAudioFilter as it is already possible for video filters using SetFilter.

rohitggarg
rohitggarg reviewed Mar 22, 2019
View reviewed changes
Copy link
Contributor

@rohitggarg rohitggarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it should be worthwhile to rename Filter to VideoFilter as well. I'd suggest making the change with keeping the SetFilter under deprecation.

@timotto
Copy link
Contributor Author

timotto commented Mar 28, 2019

As you suggested there's now a SetVideoFilter method with the SetFilter marked deprecated.

rohitggarg
rohitggarg reviewed Mar 29, 2019
View reviewed changes
models/media.go Outdated Show resolved Hide resolved
models/media.go Outdated Show resolved Hide resolved
rohitggarg
rohitggarg approved these changes Mar 30, 2019
View reviewed changes
Copy link
Contributor

@rohitggarg rohitggarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@rohitggarg
Copy link
Contributor

@xfrr care to merge?

@xfrr xfrr merged commit df9067d into xfrr:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohitggarg rohitggarg rohitggarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timotto @rohitggarg @xfrr