Added extra metadata types/fields #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is ffprobe data that is being ignored.
I am processing videos coming from phones and drones, which are rotated.
At the moment, with the current metadata there is no information in the metadata to detect rotation, HDR info, etc.
With the current library, if you resize a video that is rotated with metadata, the video will show squashed.
This is because you read from the metadata, for example 1920x1080. The you set the resolution to
SetResolution("1080x720"), ffmpeg will rotate the video automatically while converting it, but instead of being 720x1080, it will be a squashed version at 1080x720.With the new fields you can transpose the width/height if you detect that the video is rotated.