Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: issue 945 soft delete users #1583

Merged
merged 6 commits into from
Nov 26, 2024
Merged

feat: issue 945 soft delete users #1583

merged 6 commits into from
Nov 26, 2024

Conversation

joaofrparreira
Copy link
Contributor

Relates to:

Proposed Changes

  • Add Soft-delete mongoose plugin (can be used for other schemas)
  • Add soft-delete plugin to User Schema
  • Remove user from not submitted boards only, to maintain history
  • All the query's consider isDeleted field to not present data when it's true, unless the query specifies their presentation
  • Delete-user-case now also deletes the user from the open boards

@nunocaseiro

This pull request closes #945

@joaofrparreira joaofrparreira changed the title Feat/issue 945 soft delete users feat: issue 945 soft delete users Nov 13, 2024
nunocaseiro
nunocaseiro approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@nunocaseiro nunocaseiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@nunocaseiro
Copy link
Contributor

@all-contributors please add @joaofrparreira for code and tests

@allcontributors allcontributors bot mentioned this pull request Nov 19, 2024
Merged
@allcontributors AllContributors
Copy link
Contributor

@nunocaseiro

I've put up a pull request to add @joaofrparreira! 🎉

@nunocaseiro nunocaseiro merged commit 7c66f2c into xgeekshq:main Nov 26, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Soft delete users
2 participants
@joaofrparreira @nunocaseiro