Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: button primitive component normalization #949

Merged
merged 9 commits into from
Jan 30, 2023

Conversation

jpvsalvador
Copy link
Contributor

Relates to #941
Fixes #941

Proposed Changes

  • Normalize all the button behaviour throughout the application through the Button primitive component.

This pull request closes #941

@jpvsalvador jpvsalvador added bug Something isn't working frontend labels Jan 27, 2023
@jpvsalvador jpvsalvador requested a review from a team January 27, 2023 12:03
@jpvsalvador jpvsalvador linked an issue Jan 27, 2023 that may be closed by this pull request
@jpvsalvador jpvsalvador self-assigned this Jan 27, 2023
@jpvsalvador jpvsalvador marked this pull request as draft January 27, 2023 16:26
@jpvsalvador jpvsalvador marked this pull request as ready for review January 27, 2023 16:32
Copy link
Contributor

@StereoPT StereoPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🗝️

@jpvsalvador jpvsalvador merged commit da6b0e3 into main Jan 30, 2023
@jpvsalvador jpvsalvador deleted the 941-bug-button-primitive-component-normalization branch January 30, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG]: button primitive component normalization
2 participants