Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: regular board votes and quick create #996

Merged
merged 11 commits into from
Feb 3, 2023
Merged

fix: regular board votes and quick create #996

merged 11 commits into from
Feb 3, 2023

Conversation

CatiaAntunes96
Copy link
Contributor

Fixes #975

Proposed Changes

  • Regular Board votes fixed.
  • Regular Board deleting card from merged group of cards.
  • When creating a regular board, maxVotes is undefined (when not onFocus)
  • Deleted one UseEffect causing error on the console, reusing another one.
  • Fix handle votes when the card deleted belonged to the user on index 0

@patricia-mdias

This pull request closes #975

@CatiaAntunes96 CatiaAntunes96 added bug Something isn't working frontend labels Feb 2, 2023
@CatiaAntunes96 CatiaAntunes96 added this to the Full Version milestone Feb 2, 2023
@CatiaAntunes96 CatiaAntunes96 merged commit cfe9e2d into main Feb 3, 2023
@CatiaAntunes96 CatiaAntunes96 deleted the fix/regular-board-votes branch February 3, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nunocaseiro nunocaseiro nunocaseiro approved these changes

Assignees

@CatiaAntunes96 CatiaAntunes96

@patricia-mdias patricia-mdias

Labels
bug Something isn't working frontend
Projects
SPLIT • Bugs
Status: Done
Milestone
Full Version
Development

Successfully merging this pull request may close these issues.

[BUG]: Regular Board votes
4 participants
@CatiaAntunes96 @nunocaseiro @patricia-mdias @rpvsilva