Skip to content
This repository has been archived by the owner on Aug 7, 2021. It is now read-only.

Wrong url for daily Achievements. #17

Closed
Frigerius opened this issue Jun 29, 2017 · 3 comments
Closed

Wrong url for daily Achievements. #17

Frigerius opened this issue Jun 29, 2017 · 3 comments
Labels

Comments

@Frigerius
Copy link

There is a wrong URL in ur getCurrentDailyAchievements(). It queries https://api.guildwars2.com/v2/achievement/daily instead of https://api.guildwars2.com/v2/achievements/daily (u missed a "s")

@Frigerius
Copy link
Author

ah and errorResponse = new Gson().fromJson(error, ErrorResponse.class); for {"error":"not found"} produces a null String in ErrorResponse (ErrorCode line 33)

xhsun added a commit that referenced this issue Jun 30, 2017
@xhsun
Copy link
Owner

xhsun commented Jun 30, 2017

I'm aware of the bug in checkErrorResponse() and it was fixed in v1.2.1
Thanks for pointing the wrong url for achievements, I have no idea how I missed that when I was testing

@xhsun xhsun closed this as completed Jun 30, 2017
xhsun added a commit that referenced this issue Jun 30, 2017
@Frigerius
Copy link
Author

Great, thx for the fast fix.

@xhsun xhsun added the bug label Oct 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants