Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Widget: DataSet issues with duration is per item and freshness timeout #2460

Merged
merged 2 commits into from
Apr 5, 2024
Merged

Widget: DataSet issues with duration is per item and freshness timeout #2460

merged 2 commits into from
Apr 5, 2024

Conversation

dasgarner
Copy link
Member

This PR addresses two issues:

  • The freshness timeout property in DataSet does not work for Elements
  • The validation for ensuring we have a number of items makes more sense on numItems vs upperLimit

@dasgarner dasgarner self-assigned this Mar 28, 2024
maurofmferrao
maurofmferrao approved these changes Mar 28, 2024
View reviewed changes
Copy link
Member

@maurofmferrao maurofmferrao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@gracec20
Copy link

gracec20 commented Apr 3, 2024

TEST: /Layout, /Library END

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2024

Test Suite: succeeded ✅
https://github.com/xibosignage/xibo-cms/actions/runs/8537032272

@dasgarner dasgarner merged commit ecafbdd into develop Apr 5, 2024
3 checks passed
@dasgarner dasgarner deleted the bugfix/westphal_dataset_widget branch April 5, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maurofmferrao maurofmferrao maurofmferrao approved these changes

Assignees

@dasgarner dasgarner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dasgarner @gracec20 @maurofmferrao