Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataSet: trying to import without any columns logs an unhelpful error #3458

Closed
dasgarner opened this issue Jul 17, 2024 · 0 comments
Closed

DataSet: trying to import without any columns logs an unhelpful error #3458

dasgarner opened this issue Jul 17, 2024 · 0 comments
Assignees
@nadzpogi
Labels
enhancement An improvement to an existing feature
Milestone
4.1.0-rc2

Comments

@dasgarner
Copy link
Member

The error we log currently is shown below:

[2024-07-17 11:33:19] CONSOLE.DEBUG: INSERT INTO `dataset_1` (``) VALUES () [] {"method":"GET","route":"/6","uid":"a582122"}
[2024-07-17 11:33:19] CONSOLE.ERROR: run: SQLSTATE[42S22]: Column not found: 1054 Unknown column '' in 'field list' Exception Type

We could improve this message to better indicate what the problem is, and perhaps even abort the import much sooner if there are no columns configured.

Could we also put a message on the edit form to remind the user to go and configure their columns if there are no columns marked as "Remote" or none at all?
@dasgarner dasgarner added the enhancement An improvement to an existing feature label Jul 17, 2024
@dasgarner dasgarner added this to the 4.1.0-rc2 milestone Jul 17, 2024
nadzpogi added a commit to xibosignage/xibo-cms that referenced this issue Jul 31, 2024
@nadzpogi
DataSet: trying to import without any columns logs an unhelpful error…
809a27b 
… (#3458)

relates to xibosignage/xibo#3458
@nadzpogi nadzpogi mentioned this issue Jul 31, 2024
Merged
nadzpogi added a commit to xibosignage/xibo-cms that referenced this issue Aug 1, 2024
@nadzpogi
DataSet: trying to import without any columns logs an unhelpful error…
c9886d9 
… (#3458)

relates to xibosignage/xibo#3458

- Column checks now cover both manual and remote dataset imports.
nadzpogi added a commit to xibosignage/xibo-cms that referenced this issue Aug 1, 2024
@nadzpogi
DataSet: trying to import without any columns logs an unhelpful error…
922ec6b 
… (#3458)

relates to xibosignage/xibo#3458
nadzpogi added a commit to xibosignage/xibo-cms that referenced this issue Aug 7, 2024
@nadzpogi
Enhancements for DataSet column configuration checks (#2665)
94fadcc 
relates to xibosignage/xibo#3458

* Added message in the Edit DataSet Form to inform users if it has no columns configured.
* Added message in the Edit DataSet Form to inform users if it has no remote columns configured for Remote DataSets.
* Prevented importing if the DataSet has no columns configured.
* Prevented remote importing if the DataSet has no remote columns configured.
@nadzpogi nadzpogi closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadzpogi nadzpogi

Labels
enhancement An improvement to an existing feature
Projects
None yet
Milestone
4.1.0-rc2
Development

No branches or pull requests
2 participants
@dasgarner @nadzpogi