fix(react): always respect headers, even on a miss

This allows applications to always add headers THIS IS A BREAKING CHANGE
xing · Mar 12, 2018 · 0022a1c · 0022a1c
1 parent ebc0c37
commit 0022a1c
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/react/node.js b/packages/react/node.js
@@ -106,16 +106,16 @@ var renderWithContext = function(reactElement, _context) {
         timings.end('hops.react.renderTemplate');
 
         var routerContext = templateData.routerContext;
+        routerContext.headers && res.set(routerContext.headers);
+
         if (routerContext.miss) {
           next();
         } else if (routerContext.url) {
           res.status(routerContext.status || 301);
           res.set('Location', routerContext.url);
-          routerContext.headers && res.set(routerContext.headers);
           res.end();
         } else {
           res.status(routerContext.status || 200);
-          routerContext.headers && res.set(routerContext.headers);
           res.type('html');
           res.send(markup);
         }