wip upgrade apollo-client to v3 #1289
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZauberNerd
force-pushed
the
upgrade-apollo-client
branch
3 times, most recently
from
2d700c3 to
dbeafea
Compare
|
|
ZauberNerd
force-pushed
the
upgrade-apollo-client
branch
from
dbeafea to
eef2949
Compare
ZauberNerd
force-pushed
the
upgrade-apollo-client
branch
2 times, most recently
from
1489ac3 to
e370da4
Compare
ZauberNerd
force-pushed
the
upgrade-apollo-client
branch
from
e370da4 to
f779bb3
Compare
ZauberNerd
force-pushed
the
upgrade-apollo-client
branch
from
f779bb3 to
1934949
Compare
ZauberNerd
force-pushed
the
upgrade-apollo-client
branch
5 times, most recently
from
b0a256d to
f2ff50f
Compare
This upgrades all usages of react-apollo to @apollo/client v3.
BREAKING CHANGE: Support for react apollo < v3 has been removed.
In detail this means:
*New peer dependency `@apollo/client`*
The previous peer dependencies `react-apollo` and `graphql-tag` are no
longer needed.
*Fragment types have changed*
After upgrading the `fragmentTypes.json` needs to be re-created.
This can be done by running `hops graphql introspect`.
*Errored-requests no longer throw errors on the server*
Before, when a SSR request encountered a GraphQL error (such as an
invalid query, non-nullable field resolve error or a network error), it
would throw an error which meant that Hops itself would render a status
500 response with said error.
This is no longer the case and therefore all applications must now
decide in their components what kind of response they want to send.
You can use the `<Status code={123} />` component for that.
Take a look at `packages/spec/integration/graphql` for an example.
*`createFragmentMatcher` mixin hook has been removed*
This should'nt affect any applications, because it has mostly been used
internally.
ZauberNerd
force-pushed
the
upgrade-apollo-client
branch
from
f2ff50f to
7d6bbd0
Compare
|
superseded by #1648 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to wait for:Loading should not be initially true when the data is provided server-side [reproduction provided] apollographql/apollo-client#6651v3.0: loading: true for first render always, even if all data is available in cache apollographql/apollo-client#6659Bors merge bot cheat sheet
We are using bors-ng to automate merging of our pull requests. The following table provides a summary of commands that are available to reviewers (members of this repository with push access) and delegates (in case of
bors delegate+orbors delegate=[list]).This is a short collection of opinionated commands. For a full list of the commands read the bors reference.