fix(postcss): do not output custom properties in resulting css #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because this creates a lot of duplication when importing css variables files in other css files which are then imported via js. See: - postcss/postcss-import#316 - postcss/postcss-import#294 - postcss/postcss-import#224
robin-drexler
approved these changes
Aug 22, 2018
ZauberNerd
added a commit
that referenced
this pull request
Feb 25, 2020
Changes: * update dependency serialize-javascript to v3 ([1e0aadb](untool/untool@1e0aadb)) * **core:** allow to ignore certain presets through "ignoredPresets" ([1dc9422](untool/untool@1dc9422)), closes [#580](untool/untool#580) * **react:** set data-mounted attribute after hydration ([566a3a5](untool/untool@566a3a5))
bors bot
added a commit
that referenced
this pull request
Feb 25, 2020
1095: fix: upgrade untool to v2.1.3 r=KnisterPeter a=ZauberNerd Changes: * update dependency serialize-javascript to v3 ([1e0aadb](untool/untool@1e0aadb)) * **core:** allow to ignore certain presets through "ignoredPresets" ([1dc9422](untool/untool@1dc9422)), closes [#580](untool/untool#580) * **react:** set data-mounted attribute after hydration ([566a3a5](untool/untool@566a3a5)) Co-authored-by: ZauberNerd <zaubernerd@zaubernerd.de>
ZauberNerd
added a commit
that referenced
this pull request
Feb 25, 2020
Changes: * update dependency serialize-javascript to v3 ([1e0aadb](untool/untool@1e0aadb)) * **core:** allow to ignore certain presets through "ignoredPresets" ([1dc9422](untool/untool@1dc9422)), closes [#580](untool/untool#580) * **react:** set data-mounted attribute after hydration ([566a3a5](untool/untool@566a3a5))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because this creates a lot of duplication when importing css variables
files in other css files which are then imported via js.
See: