Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ilog64 const #1465

Closed
wants to merge 1 commit into from
Closed

Conversation

lu-zero
Copy link
Collaborator

@lu-zero lu-zero commented Jul 20, 2019

leading_zeroes and this kind of functions are const-ready since 1.34.0
We neeed rust-lang/rust#57349 to constantize
further.

(first step in #1464)

leading_zeroes and this kind of functions are const-ready since 1.34.0
We neeed rust-lang/rust#57349 to constantize
further.
@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 81.225% when pulling 407b841 on rust-av:const-all-the-things into 5ec045c on xiph:master.

@rzumer rzumer mentioned this pull request Jul 20, 2019
@@ -86,7 +86,7 @@ const DQP_Q57: &[i64; FRAME_NSUBTYPES] = &[
// This is the number of bits that would be required to represent v in two's
// complement notation with all of the leading zeros stripped.
// TODO: Mark const once leading_zeros() as a constant function stabilizes.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this TODO as part of this

@rzumer
Copy link
Collaborator

rzumer commented Jul 26, 2019

Closing in favor of #1466 until const fn is supported for trait functions.

@rzumer rzumer closed this Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants