Remove core-lro runtime dependency on core-http

Fixes Azure#15880
xirzec · Jun 21, 2021 · 40dcfb9 · 40dcfb9
1 parent 5da2922
commit 40dcfb9
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/sdk/core/core-lro/package.json b/sdk/core/core-lro/package.json
@@ -96,12 +96,12 @@
   "sideEffects": false,
   "dependencies": {
     "@azure/abort-controller": "^1.0.0",
-    "@azure/core-http": "^1.2.0",
     "@azure/core-tracing": "1.0.0-preview.12",
     "events": "^3.0.0",
     "tslib": "^2.2.0"
   },
   "devDependencies": {
+    "@azure/core-http": "^1.2.0",
     "@azure/eslint-plugin-azure-sdk": "^3.0.0",
     "@azure/dev-tool": "^1.0.0",
     "@microsoft/api-extractor": "7.7.11",

diff --git a/sdk/core/core-lro/rollup.base.config.js b/sdk/core/core-lro/rollup.base.config.js
@@ -27,6 +27,7 @@ const banner = [
 ].join("\n");
 
 const depNames = Object.keys(pkg.dependencies);
+const devDepNames = Object.keys(pkg.devDependencies);
 const production = process.env.NODE_ENV === "production";
 
 export function nodeConfig(test = false) {
@@ -59,6 +60,9 @@ export function nodeConfig(test = false) {
     baseConfig.input = ["dist-esm/test/*.test.js"];
     baseConfig.plugins.unshift(multiEntry({ exports: false }));
 
+    // mark devdeps as external
+    baseConfig.external.push(...devDepNames);
+
     // different output file
     baseConfig.output.file = "dist-test/index.node.js";
 
@@ -85,9 +89,6 @@ export function browserConfig(test = false) {
       banner: banner,
       format: "umd",
       name: "azurecorelro",
-      globals: {
-        "@azure/core-http": "Azure.Core.HTTP"
-      },
       sourcemap: true
     },
     preserveSymlinks: false,