-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the possibility to have a property file for all classes by not ch… #117
add the possibility to have a property file for all classes by not ch… #117
Conversation
Thanks for the PR @mueller-jens . I'll review this soon |
9b89048
to
5d473d7
Compare
Hi @MikeEdgar, give me a hint if I should clean something up or if i can help you in an other way. |
Thanks @mueller-jens , I was trying to get the CI working. I hadn't updated the build and quality analysis on this repo in a while, so it's taking a bit longer 😄 The PR is generally looking pretty good. |
…ange te actual behavior; adjust test classes to work with not english locale and not linux systems
Signed-off-by: Michael Edgar <michael@xlate.io>
05ceb09
to
2ed45ab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few small items identified by the sonar scanner.
src/main/java/io/xlate/inject/PropertyResourceProducerBean.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Michael Edgar <michael@xlate.io>
Co-authored-by: Michael Edgar <michael@xlate.io>
Co-authored-by: Michael Edgar <michael@xlate.io>
Co-authored-by: Michael Edgar <michael@xlate.io>
Hi @MikeEdgar, have applied your suggestions. |
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, any other updates on your side @mueller-jens ?
No futher updates at the moment. |
…ange te actual behavior; adjust test classes to work with not english locale and not linux systems
Here an purposal to solve my requirement to have a global propertyfile, whithout touching the old behavior and the possiblilty to override the values locally.
To configure a global propertyfile the user has to implement a bean like this example:
Also I have adapted some tests to work also on system with different locale than english and the file resolver to use it in windows environment too.