chore: code smell

Signed-off-by: iGxnon <igxnon@gmail.com>
xline-kv · Jan 9, 2024 · a4fe329 · a4fe329
1 parent b6b9f73
commit a4fe329
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 8 deletions.
diff --git a/curp/src/client/mod.rs b/curp/src/client/mod.rs
@@ -144,7 +144,7 @@ trait LeaderStateUpdate {
 }
 
 /// Client builder to build a client
-#[derive(Debug, Clone)]
+#[derive(Debug, Clone, Default)]
 #[allow(clippy::module_name_repetitions)] // better than just Builder
 pub struct ClientBuilder {
     /// initial cluster version
@@ -175,10 +175,8 @@ impl ClientBuilder {
     #[must_use]
     pub fn new(config: ClientConfig) -> Self {
         Self {
-            cluster_version: None,
-            all_members: None,
-            leader_state: None,
             config,
+            ..ClientBuilder::default()
         }
     }
 

diff --git a/xline/src/storage/compact/periodic_compactor.rs b/xline/src/storage/compact/periodic_compactor.rs
@@ -87,7 +87,6 @@ impl<C: Compactable> PeriodicCompactor<C> {
     }
 
     /// perform auto compaction logic
-    #[allow(clippy::pattern_type_mismatch)] // allow let Some matching
     async fn do_compact(
         &self,
         last_revision: Option<i64>,
@@ -108,7 +107,7 @@ impl<C: Compactable> PeriodicCompactor<C> {
             revision, self.period
         );
 
-        let Some(compactable) = &*self.compactable.read().await else {
+        let Some(ref compactable) = *self.compactable.read().await else {
             return None;
         };
 

diff --git a/xline/src/storage/compact/revision_compactor.rs b/xline/src/storage/compact/revision_compactor.rs
@@ -50,7 +50,6 @@ impl<C: Compactable> RevisionCompactor<C> {
     }
 
     /// perform auto compaction logic
-    #[allow(clippy::pattern_type_mismatch)] // allow let Some matching
     async fn do_compact(&self, last_revision: Option<i64>) -> Option<i64> {
         if !self.is_leader.load(Relaxed) {
             return None;
@@ -67,7 +66,7 @@ impl<C: Compactable> RevisionCompactor<C> {
             target_revision, self.retention
         );
 
-        let Some(compactable) = &*self.compactable.read().await else {
+        let Some(ref compactable) = *self.compactable.read().await else {
             return None;
         };