Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Features/lock #153

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Features/lock #153

merged 1 commit into from
Jan 31, 2023

Conversation

themanforfree
Copy link
Collaborator

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Support lock service
  • what changes does this pull request make?
    Support lock service
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    No

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Merging #153 (bab31e1) into master (1a15496) will increase coverage by 6.29%.
The diff coverage is 81.06%.

@@            Coverage Diff             @@
##           master     #153      +/-   ##
==========================================
+ Coverage   64.07%   70.37%   +6.29%     
==========================================
  Files          61       61              
  Lines       10452    10638     +186     
==========================================
+ Hits         6697     7486     +789     
+ Misses       3755     3152     -603     
Impacted Files Coverage Δ
xline/src/rpc/mod.rs 73.39% <ø> (+9.17%) ⬆️
xline/src/server/kv_server.rs 62.08% <0.00%> (ø)
xline/src/storage/auth_store/perms.rs 87.75% <0.00%> (-12.25%) ⬇️
xline/src/storage/auth_store/store.rs 77.06% <28.94%> (+0.85%) ⬆️
xline/src/client/mod.rs 61.70% <44.44%> (+9.70%) ⬆️
xline/src/state.rs 86.86% <89.74%> (+1.86%) ⬆️
xline/src/server/lock_server.rs 93.49% <92.72%> (+87.75%) ⬆️
xline/src/server/lease_server.rs 70.00% <100.00%> (+59.95%) ⬆️
xline/src/server/watch_server.rs 68.72% <100.00%> (+11.51%) ⬆️
xline/src/server/xline_server.rs 86.16% <100.00%> (+0.08%) ⬆️
... and 23 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@themanforfree themanforfree force-pushed the features/lock branch 2 times, most recently from e97e892 to d469009 Compare January 31, 2023 02:23
@themanforfree themanforfree marked this pull request as ready for review January 31, 2023 02:27
xline/src/server/lock_server.rs Outdated Show resolved Hide resolved
xline/src/server/kv_server.rs Show resolved Hide resolved
xline/src/server/xline_server.rs Outdated Show resolved Hide resolved
xline/src/client/mod.rs Show resolved Hide resolved
@themanforfree themanforfree force-pushed the features/lock branch 2 times, most recently from eefaa72 to cf386ba Compare January 31, 2023 10:13
@mergify mergify bot merged commit 2f4de6c into xline-kv:master Jan 31, 2023
@themanforfree themanforfree deleted the features/lock branch February 1, 2023 02:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants