Feature/rocksdb engine #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Phoenix500526
force-pushed
the
feature/rocksdb-engine
branch
from
72d16d7
to
62fdd9a
Compare
Codecov Report
@@ Coverage Diff @@
## master #187 +/- ##
==========================================
+ Coverage 45.92% 46.58% +0.66%
==========================================
Files 65 66 +1
Lines 10104 10348 +244
==========================================
+ Hits 4640 4821 +181
- Misses 5464 5527 +63
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Phoenix500526
force-pushed
the
feature/rocksdb-engine
branch
2 times, most recently
from
4850f58
to
09214af
Compare
Phoenix500526
force-pushed
the
feature/rocksdb-engine
branch
2 times, most recently
from
f6facce
to
7fcffb9
Compare
Phoenix500526
requested review from
rogercloud,
markcty and
themanforfree
and removed request for
rogercloud,
markcty and
themanforfree
markcty
suggested changes
Mar 6, 2023
Closed
Phoenix500526
force-pushed
the
feature/rocksdb-engine
branch
from
d063281
to
e8f3297
Compare
|
The first commit |
Phoenix500526
force-pushed
the
feature/rocksdb-engine
branch
4 times, most recently
from
7dbf926
to
1354ef6
Compare
- Refactor WriteOperation implementation - add a default storage setting - add error translation method Close xline-kv#183
Phoenix500526
force-pushed
the
feature/rocksdb-engine
branch
3 times, most recently
from
1022d9c
to
22f5165
Compare
markcty
previously approved these changes
Mar 8, 2023
use default_XXX function to initialize the default value for some command line args, like `retry_timeout`, `heartbeat_interval`.
Phoenix500526
force-pushed
the
feature/rocksdb-engine
branch
from
22f5165
to
81e0639
Compare
markcty
approved these changes
Mar 8, 2023
themanforfree
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
This is the second pr based on #185, described in issue #183
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)