Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/issue 299 #302

Merged
merged 3 commits into from
Jun 6, 2023
Merged

Fix/issue 299 #302

merged 3 commits into from
Jun 6, 2023

Conversation

Phoenix500526
Copy link
Collaborator

Please briefly answer these questions:
Fix issue #299 .

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    Read issue Refactor: sharing state between CurpServer and CurpClient #299 for more details.

  • what changes does this pull request make?

  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)

@Phoenix500526 Phoenix500526 added this to the Release v0.4.1 milestone Jun 2, 2023
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Merging #302 (8fd26fc) into master (23a84d2) will increase coverage by 0.46%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
+ Coverage   54.23%   54.69%   +0.46%     
==========================================
  Files          75       75              
  Lines       12295    12385      +90     
  Branches    12295    12385      +90     
==========================================
+ Hits         6668     6774     +106     
+ Misses       5192     5168      -24     
- Partials      435      443       +8     
Impacted Files Coverage Δ
curp/src/client.rs 4.40% <0.00%> (-7.84%) ⬇️
curp/src/server/curp_node.rs 24.26% <0.00%> (-0.16%) ⬇️
curp/src/server/mod.rs 0.00% <0.00%> (ø)
curp/src/server/raw_curp/mod.rs 62.91% <0.00%> (-0.74%) ⬇️
xline/src/client/mod.rs 0.00% <0.00%> (ø)
xline/src/server/lease_server.rs 0.00% <0.00%> (ø)
xline/src/server/xline_server.rs 0.00% <0.00%> (ø)

... and 6 files with indirect coverage changes

curp/src/client.rs Outdated Show resolved Hide resolved
curp/src/client.rs Show resolved Hide resolved
curp/src/client.rs Outdated Show resolved Hide resolved
xline/src/client/mod.rs Outdated Show resolved Hide resolved
@Phoenix500526 Phoenix500526 merged commit 2f0b026 into xline-kv:master Jun 6, 2023
@Phoenix500526 Phoenix500526 deleted the fix/issue-299 branch June 6, 2023 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: sharing state between CurpServer and CurpClient
4 participants