-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issue 299 #302
Merged
Merged
Fix/issue 299 #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #302 +/- ##
==========================================
+ Coverage 54.23% 54.69% +0.46%
==========================================
Files 75 75
Lines 12295 12385 +90
Branches 12295 12385 +90
==========================================
+ Hits 6668 6774 +106
+ Misses 5192 5168 -24
- Partials 435 443 +8
|
Phoenix500526
force-pushed
the
fix/issue-299
branch
from
June 2, 2023 03:59
eb6d07d
to
8803abd
Compare
Phoenix500526
force-pushed
the
fix/issue-299
branch
from
June 2, 2023 09:44
8803abd
to
d7bb73e
Compare
rogercloud
reviewed
Jun 4, 2023
Phoenix500526
force-pushed
the
fix/issue-299
branch
from
June 5, 2023 01:20
d7bb73e
to
dfdb2a1
Compare
bsbds
reviewed
Jun 5, 2023
Phoenix500526
force-pushed
the
fix/issue-299
branch
from
June 6, 2023 06:01
79a46ab
to
8fd26fc
Compare
rogercloud
approved these changes
Jun 6, 2023
themanforfree
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
Fix issue #299 .
what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
Read issue Refactor: sharing state between CurpServer and CurpClient #299 for more details.
what changes does this pull request make?
are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)