Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/refactor: fix propose doesn't handle SyncedError and reduce code duplication #407

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

themanforfree
Copy link
Collaborator

Please briefly answer these questions:

  • what problem are you trying to solve? (or if there's no problem, what's the motivation for this change?)
    fix propose doesn't handle SyncedError
  • what changes does this pull request make?
    return an Error instead of unreachable, and do some refactor to reduce code duplication
  • are there any non-obvious implications of these changes? (does it break compatibility with previous versions, etc)
    no

@codecov
Copy link

codecov bot commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.09% 🎉

Comparison is base (9b747ec) 53.60% compared to head (0c47d3a) 53.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #407      +/-   ##
==========================================
+ Coverage   53.60%   53.69%   +0.09%     
==========================================
  Files         102      101       -1     
  Lines       15944    15913      -31     
  Branches    15944    15913      -31     
==========================================
- Hits         8546     8545       -1     
+ Misses       6878     6847      -31     
- Partials      520      521       +1     
Files Changed Coverage Δ
curp/src/client.rs 5.16% <0.00%> (+0.01%) ⬆️
xline-client/src/clients/auth.rs 0.00% <0.00%> (ø)
xline-client/src/clients/kv.rs 0.00% <0.00%> (ø)
xline-client/src/clients/lease.rs 0.00% <0.00%> (ø)
xline-client/src/clients/lock.rs 0.00% <0.00%> (ø)
xline/src/client/mod.rs 0.00% <0.00%> (ø)
xline/src/server/auth_server.rs 0.00% <0.00%> (ø)
xline/src/server/command.rs 68.06% <0.00%> (-4.84%) ⬇️
xline/src/server/kv_server.rs 37.46% <0.00%> (+1.88%) ⬆️
xline/src/server/lease_server.rs 0.00% <0.00%> (ø)
... and 3 more

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: themanforfree <themanforfree@gmail.com>
@Phoenix500526 Phoenix500526 linked an issue Aug 7, 2023 that may be closed by this pull request
1 task
@themanforfree themanforfree merged commit 5126802 into xline-kv:master Aug 8, 2023
16 of 17 checks passed
@themanforfree themanforfree deleted the fix/sync-response branch August 8, 2023 03:53
@Phoenix500526 Phoenix500526 added the bug Something isn't working label Nov 18, 2023
@Phoenix500526 Phoenix500526 added this to the v0.6.0 milestone Nov 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: test_kv_authorization run unreachable code
4 participants