-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix/refactor: fix propose doesn't handle SyncedError and reduce code duplication #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #407 +/- ##
==========================================
+ Coverage 53.60% 53.69% +0.09%
==========================================
Files 102 101 -1
Lines 15944 15913 -31
Branches 15944 15913 -31
==========================================
- Hits 8546 8545 -1
+ Misses 6878 6847 -31
- Partials 520 521 +1
☔ View full report in Codecov by Sentry. |
themanforfree
force-pushed
the
fix/sync-response
branch
from
August 1, 2023 00:57
53c228b
to
6880016
Compare
themanforfree
force-pushed
the
fix/sync-response
branch
from
August 1, 2023 08:01
a30b897
to
b7c8e97
Compare
themanforfree
force-pushed
the
fix/sync-response
branch
from
August 7, 2023 02:16
b7c8e97
to
189496c
Compare
Signed-off-by: themanforfree <themanforfree@gmail.com>
themanforfree
force-pushed
the
fix/sync-response
branch
from
August 7, 2023 02:41
189496c
to
0c47d3a
Compare
Phoenix500526
approved these changes
Aug 7, 2023
1 task
bsbds
reviewed
Aug 8, 2023
bsbds
approved these changes
Aug 8, 2023
iGxnon
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please briefly answer these questions:
fix propose doesn't handle
SyncedError
return an
Error
instead ofunreachable
, and do some refactor to reduce code duplicationno