fix: CURP TLA+ quorum size calculation & property check #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #418 +/- ##
=======================================
Coverage 54.10% 54.10%
=======================================
Files 101 101
Lines 16251 16251
Branches 16251 16251
=======================================
Hits 8793 8793
Misses 6930 6930
Partials 528 528 ☔ View full report in Codecov by Sentry. |
rogercloud
approved these changes
Aug 19, 2023
Phoenix500526
previously approved these changes
Aug 20, 2023
Signed-off-by: EAimTY <EAimTY@users.noreply.github.com>
Phoenix500526
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous TLA+ specification of CURP had several issues:
The first problem is fixed by calculating quorum size using the maximum number of faulty participants
f.To solve the second problem, the detailed messaging abstraction between server and client is removed in favor of a much simpler system-wide consensus decision abstraction. The client-side details are omitted since they are not the main focus of this model.