onedpl add fetch.lua #4324
Merged
onedpl add fetch.lua #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/* MACROS DUE TO llvm/llvm-project@3b9a1bb#diff-4c6821476cefc699b801f5fdbeda3341e3c64626dcf39a79621ea02031bdd50eL113 */ /* ALSO C.F. oneapi-src/oneDPL#1602 */ /* AND THE USING OF _PSTL_... MACROS IS REMOVED FROM ONEDPL NOWADAYS*/
typo
ci on arch linux failed due to network error
|
io.replace(...pstl/...): c.f. llvm/llvm-project@3b9a1bb#diff-4c6821476cefc699b801f5fdbeda3341e3c64626dcf39a79621ea02031bdd50eL113 |
waruqi
reviewed
Jun 11, 2024
| @@ -5,17 +5,36 @@ package("onedpl") | |||
| set_description("oneAPI DPC++ Library") | |||
|
|
|||
| add_urls("https://github.com/oneapi-src/oneDPL/archive/refs/tags/oneDPL-$(version)-release.tar.gz") | |||
| add_urls("https://github.com/oneapi-src/oneDPL/archive/refs/tags/oneDPL-$(version).tar.gz") | |||
There was a problem hiding this comment.
如果以后出了新的，它是-release.tar.gz而不是.rc?.tar.gz,是不是还要把顺序换回来o.O我在想或者直接把release写到版本号得了
There was a problem hiding this comment.
参考 sqlite3 的包，写 version function
waruqi
reviewed
Jun 11, 2024
packages/o/onedpl/fetch.lua
Outdated
|
|
||
| function _find_package(package, opt) | ||
| local paths = { | ||
| "$(env DPL_ROOT)", |
waruqi
reviewed
Jun 11, 2024
packages/o/onedpl/fetch.lua
Outdated
| local backend = package:config("backend") | ||
|
|
||
| if backend == "tbb" or backend == "dpcpp" then | ||
| package:add("deps", "tbb") |
waruqi
reviewed
Jun 11, 2024
packages/o/onedpl/fetch.lua
Outdated
| package:add("deps", "openmp") | ||
| end | ||
| if package:is_plat("windows") then | ||
| package:add("cxxflags", "/Zc:__cplusplus") |
remove unnecessary add_deps
waruqi
reviewed
Jun 11, 2024
packages/o/onedpl/fetch.lua
Outdated
| end | ||
|
|
||
| if #result.includedirs > 0 then | ||
| local version_file = path.join(includepath, "oneapi","dpl","pstl","onedpl_config.h") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested with TBB backend
and it should work for omp backend
I wonder if TBB links/linkdirs should be explicitly added or these can be implicitly inferred after adding package deps ("openmp")?