-
-
Notifications
You must be signed in to change notification settings - Fork 810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve precompiled binary package compatibility on windows/msvc #1513
Comments
https://docs.microsoft.com/en-us/cpp/porting/binary-compat-2015-2017?view=msvc-160
|
so it's just backwards compatible |
ok, I only need to use vs2015 to compile all libraries, and only support pre-compiled binaries for compilers above 2015? |
If it's applicable it would be good the precompiled binary from the latest visual studio is provided besides the compatibility version, since better performance could be gained with a more recent compiler |
Will do this, and I think it should be better to identify based on the toolset version instead of the vs version. |
In addition, I don’t know if github action has native support for switching msvc toolset, but I saw this |
GitHub Actions is not plan to support VS2015 any more. It would be better switch to AppVeyor or some other ci platform. |
I saw that github ci has vs2015 and vs2019, I will switch to 2015 later https://github.com/xmake-mirror/build-artifacts/runs/3076171663?check_suite_focus=true |
The free plan of other ci does not support parallel compilation and will be very slow. |
GitHub ci has vs2015 but there is no corresponding msbuild/v140 configuration path. ohmm.. |
Maybe at present I can only limit to >= vs2019 to support pre-compiled packages |
But I see that the toolset version in vs2019 used on the github action is 14.29, which means that as long as the user's compiler toolset >=14.2, it should be compatible. Maybe some users' VS2017 toolset can also match this requirement. |
I have improved xmake dev, and only enable pre-compiled installation for toolset >= 14.29 on ci The pre-compilation service has also been adjusted, version 2.5.5 can only temporarily disable the new pre-compiled package, and wait for the subsequent xmake release In addition, dynamic libraries and executable packages are not affected by toolset |
Now, I have added v14.16 toolset pre-compiled package support, which can support compilers above vs2017.
If the user has a higher version compiler, the 14.29 toolset package will be selected first. https://github.com/xmake-mirror/build-artifacts/blob/main/packages/o/opencv/4.5.2/manifest.txt |
issue1
vs2017
xmake-io/xmake-repo#496
issue2
vs2013
https://ci.appveyor.com/project/waruqi/xmake/builds/39973970
The text was updated successfully, but these errors were encountered: