Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve tab complete #673

Merged
merged 20 commits into from
Jan 21, 2020
Merged

improve tab complete #673

merged 20 commits into from
Jan 21, 2020

Conversation

OpportunityLiu
Copy link
Member

  • Before adding new features and new modules, please go to issues to submit the relevant feature description first.
  • Write good commit messages and use the same coding conventions as the rest of the project.
  • Please commit code to dev branch and we will merge into master branch in feature
  • Ensure your edited codes with four spaces instead of TAB.

  • 增加新特性和新模块之前,请先到issues提交相关特性说明,经过讨论评估确认后,再进行相应的代码提交,避免做无用工作。
  • 编写友好可读的提交信息,并使用与工程代码相同的代码规范,代码请用4个空格字符代替tab缩进。
  • 请提交代码到dev分支,如果通过,我们会在特定时间合并到master分支上。
  • 为了规范化提交日志的格式,commit消息,不要用中文,请用英文描述。

@OpportunityLiu
Copy link
Member Author

基本上可以推理的地方都给加上了

xmake/core/theme/theme.lua Outdated Show resolved Hide resolved
xmake/plugins/lua/main.lua Outdated Show resolved Hide resolved
xmake/plugins/lua/xmake.lua Outdated Show resolved Hide resolved
@OpportunityLiu
Copy link
Member Author

好吧,并不能。。 isaacs/github#436

@waruqi
Copy link
Member

waruqi commented Jan 20, 2020

好吧,并不能。。 isaacs/github#436

额。。

scripts/get.sh Outdated Show resolved Hide resolved
@waruqi
Copy link
Member

waruqi commented Jan 21, 2020

不知道为啥,我这bash下 tab complete完全失效了,task都tab不出来, macos上

xmake lua --root private.utils.complete 0 conf 'xmake crea'

返回空的,我改成zsh里面的 nospace,可以tab出来

xmake lua --root private.utils.complete 0 nospace 'xmake crea'
create

另外create里面的languages什么的也还是不行

xmake lua --root private.utils.complete 0 nospace 'xmake create -l dla'

mode和arch的tab也不行

 xmake f --arch=x8
 xmake f --arch=--arch=x86
 xmake f --mode=
 xmake f --mode=--mode=

@waruqi
Copy link
Member

waruqi commented Jan 21, 2020

termux上试了下 task和参数名能tab ,不过 ---mode --arch 还有xmake create里面的values 还是tab不出来

macos上我晚上再试试

@OpportunityLiu
Copy link
Member Author

再试试吧。。bash这个完成函数真的有够奇葩

@OpportunityLiu
Copy link
Member Author

别人都是按空格分割,它居然还按等号分割,更奇葩的是,你在等号后面按tab的时候,它送进来的正在完成的参数是"="。。。

@waruqi
Copy link
Member

waruqi commented Jan 21, 2020

再试试吧。。bash这个完成函数真的有够奇葩

mac/termux 的 bash下,task 和 target补全ok,但是参数values补全还是不行,效果跟之前一样

我刚试了下docker/ubuntu16.04下,用的 /bin/sh,连task的补全也没反应,似乎tab没生效

@OpportunityLiu
Copy link
Member Author

你有重新source一下.xmake/profile吗?改过了

@OpportunityLiu
Copy link
Member Author

参数简写的补全没支持,corner case太多懒得弄了,反正有补全的情况下写全写也很容易

@OpportunityLiu
Copy link
Member Author

sh肯定不行的,现在只支持bash zsh和pwsh

@waruqi
Copy link
Member

waruqi commented Jan 21, 2020

参数简写的补全没支持,corner case太多懒得弄了,反正有补全的情况下写全写也很容易

恩 bash上 source后可以了,不过确实只能long name,不过也够用了

@waruqi
Copy link
Member

waruqi commented Jan 21, 2020

ubuntu上我切到bash也可以,sh不行也没啥,先这样吧

@waruqi waruqi merged commit 99cafe9 into xmake-io:dev Jan 21, 2020
@OpportunityLiu
Copy link
Member Author

PowerShell/PowerShell#3633

原来是个bug,我还一直以为是什么feature。。

不说了,去升级了

@waruqi
Copy link
Member

waruqi commented Jan 25, 2020

额。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants