Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reserve these parameters for the HTTP request before upgrading to WebSocket protocol #7

Merged
merged 4 commits into from
Apr 23, 2021

Conversation

fawdlstty
Copy link
Contributor

此pr修复两个问题:

  1. 头文件引用异常#6
  2. http链接升级为websocket链接后,依旧能读取http请求带的参数
    • 示例带参数请求:ws://127.0.0.1:8080/ws?key=value

xfinal/websokcet.hpp Outdated Show resolved Hide resolved
@@ -3,7 +3,7 @@
#include <tuple>
#include "string_view.hpp"
#include <vector>
#include <filesystem.hpp>
#include "ghc/filesystem.hpp"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

头文件的问题,如果单独测试xfinal通过,应该作为单独的pr提交

xfinal/connection.hpp Outdated Show resolved Hide resolved
xfinal/http_handler.hpp Outdated Show resolved Hide resolved
@xmh0511 xmh0511 changed the title add websocket param Reserve these parameters for the HTTP request before upgrading to WebSocket protocol Apr 22, 2021
xfinal/connection.hpp Outdated Show resolved Hide resolved
fawdlstty and others added 2 commits April 23, 2021 00:47
fix a bug that empty data caused webosocket to throw an exception
@xmh0511 xmh0511 merged commit 1c53b7e into xmh0511:master Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants