Bugfix unescape entities #123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
force-pushed
the
bugfix-unescape-entities2
branch
from
6bc5f05 to
2bdae01
Compare
Character references are defined here: https://www.w3.org/TR/xml/#dt-charref CharRef ::= '&#' [0-9]+ ';' | '&#x' [0-9a-fA-F]+ ';' This test includes the use of the snake emoji U+1F40D, which is encoded as two characters in UTF-16 (used by JavaScript).
This allows unescapeXML to correctly parse strings like @ (@) and complex sequences like 🐍 (U+1F40D, Snake).
The normal numeric entity escaping now takes care of these characters.
When a character reference is outside the bounds defined by XML v1.0, throw an error, seeing as the characters are not legal, and the document is invalid. Not doing this would probably open up attack vectors allowing the entry of binary data and control sequences into data structures.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
thanks and credit @mogsie
rebase of #119