Improve performance of unescapeXML #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
reviewed
Sep 26, 2018
| @@ -49,6 +49,9 @@ vows.describe('escape').addBatch({ | |||
| 'unescapes \'': function () { | |||
| assert.strictEqual(unescapeXML('''), '\'') | |||
| }, | |||
| 'leaves invalid entities alone': function () { | |||
| assert.strictEqual(unescapeXML('&foobar;'), '&foobar;') | |||
| }, | |||
There was a problem hiding this comment.
That was my first inclination, and my first implementation, but I didn't want to break backwards compatibility, so I decided to write a test that verified that the behaviour didn't change. If anything, that might be better to put in a different PR.
There was a problem hiding this comment.
sounds sane :) good candidate for release 3.0
Merged
added 2 commits
September 28, 2018 15:10
Invalid entities are passed through silently, meaning that "<a>&foobar;</a>" is allowed, even though it technically isn't valid XML. In order to preserve backwards compatibility, this test has been added to avoid changing this behaviour.
The original replace function uses a regular expression to find expressions to parse. It is more efficient to use the indexOf to find the first matching '&' character and then the matching ';' character. Fixes half of xmppjs#120.
mogsie
force-pushed
the
performance-escape
branch
from
83a52f2 to
8fccfe3
Compare
|
parsers suite before: Node.js v10.11.0 - Intel(R) Core(TM) i5-2520M CPU @ 2.50GHz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Half of #120 fixed by this change.