Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12 compilation problems #195

Closed
ZJONSSON opened this issue Apr 30, 2019 · 2 comments
Closed

Node 12 compilation problems #195

ZJONSSON opened this issue Apr 30, 2019 · 2 comments

Comments

@ZJONSSON
Copy link

ZJONSSON commented Apr 30, 2019

@astro Looks like major changes in v8 are causing problems with node-expat under node 12. Did a quick stab fixing the obvious things but this seems to be relatively complicated and possibly interrelated with NaN
For reference see nodejs/node#23122 and bcoin-org/bcrypto#7

./node-expat.cc: At global scope:
../node-expat.cc:11:26: error: ‘Handle’ has not been declared
   static void Initialize(Handle<Object> target)
                          ^~~~~~
../node-expat.cc:11:32: error: expected ‘,’ or ‘...’ before ‘<’ token
   static void Initialize(Handle<Object> target)
                                ^
../node-expat.cc:481:23: error: ‘Handle’ has not been declared
   void Emit(int argc, Handle<Value> argv[])
                       ^~~~~~
../node-expat.cc:481:29: error: expected ‘,’ or ‘...’ before ‘<’ token
   void Emit(int argc, Handle<Value> argv[])
                             ^
../node-expat.cc: In static member function ‘static void Parser::Initialize(int)’:
../node-expat.cc:29:5: error: ‘target’ was not declared in this scope
     target->Set(Nan::New("Parser").ToLocalChecked(), t->GetFunction());
     ^~~~~~
../node-expat.cc:29:5: note: suggested alternative: ‘Parse’
     target->Set(Nan::New("Parser").ToLocalChecked(), t->GetFunction());
     ^~~~~~
     Parse
../node-expat.cc:29:69: error: no matching function for call to ‘v8::FunctionTemplate::GetFunction()’
     target->Set(Nan::New("Parser").ToLocalChecked(), t->GetFunction());
....

(for reference I have no problems doing the same install under node 11)

@Y--
Copy link
Collaborator

Y-- commented May 2, 2019

Hi all!

Thanks for this great package!
I've made a PR for Node 12 here #196

Let me know if I missed anything.

Thanks!

@Y--
Copy link
Collaborator

Y-- commented May 29, 2019

This should be fixed now. I've released version 2.3.18 that supports Node 12.
Let me know if I've missed anything.

@Y-- Y-- closed this as completed May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants