Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for Node 12 #196

Merged
merged 4 commits into from
May 29, 2019
Merged

Update for Node 12 #196

merged 4 commits into from
May 29, 2019

Conversation

Y--
Copy link
Collaborator

@Y-- Y-- commented May 2, 2019

No description provided.

@Y-- Y-- mentioned this pull request May 2, 2019
@tomkel
Copy link
Collaborator

tomkel commented May 3, 2019

@astro

@p3x-robot
Copy link
Contributor

@astro is it possible to resolve this issue?

@gajus
Copy link

gajus commented May 8, 2019

Published https://www.npmjs.com/package/xml2json-temporary as a temporary workaround.

@herbrandson
Copy link

@astro would you mind chiming in and letting us know if this is something you're planning on getting to or if this is a repo that is no longer being maintained?

@tomkel
Copy link
Collaborator

tomkel commented May 20, 2019

I tried emailing him, but no response.

@p3x-robot
Copy link
Contributor

what is weird is that @astro is actively commiting on other repos, but looks like he does not give attention to this repo

@p3x-robot
Copy link
Contributor

@gajus can we just republish it with a proper npm? it giving this error:

16:28:27 npm ERR! path /var/lib/jenkins/workspace/NG-IVR-DUOVILL/node_modules/xml2json-temporary
16:28:27 npm ERR! code EISGIT
16:28:27 npm ERR! git /var/lib/jenkins/workspace/NG-IVR-DUOVILL/node_modules/xml2json-temporary: Appears to be a git repo or submodule.
16:28:27 npm ERR! git     /var/lib/jenkins/workspace/NG-IVR-DUOVILL/node_modules/xml2json-temporary
16:28:27 npm ERR! git Refusing to remove it. Update manually,

@gajus
Copy link

gajus commented May 27, 2019

I suggest contact NPM support and saying that the author is unresponsive. If the author does not respond within 14 days, the package will be handed over to whoever requests to takeover the namespace. I would also include reference to this issue.

@Y--
Copy link
Collaborator Author

Y-- commented May 28, 2019

I just sent an e-mail to NPM's support team, will let you know here what they suggest.

Copy link
Collaborator

@tomkel tomkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So @astro made me a committer, but I can't really say if this is a solid commit or not, it's out of my wheelhouse, can someone else chime in?
well, he said he would

@astro
Copy link
Collaborator

astro commented May 29, 2019

Hi

It's great that this code is broadly used and that people try to contribute. It has been only two weeks since @tomkel reached out and his e-mail address bounced. Please be a bit more patient. :)

Is there anyone else who would like to share the joy of reviewing PRs and helping @tomkel with the release process?

@Y--
Copy link
Collaborator Author

Y-- commented May 29, 2019

Hi @astro!

I'm happy to be a contributor and review PRs if/when need be.
Feel free to contact me directly if you want to discuss it more :-)

Thanks,

Y.

@Y-- Y-- merged commit c48d4d2 into xmppo:master May 29, 2019
@Y--
Copy link
Collaborator Author

Y-- commented May 29, 2019

Thanks again @astro for allowing me to contribute to this project.
As you all might already have seen by now, I've merged this PR and released 2.3.18 that contains these changes. Let me know if I've missed anything. Thanks!

johnmuth added a commit to thirdiron/xml-stream that referenced this pull request Mar 18, 2020
@JeremyTX JeremyTX mentioned this pull request Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants