Key Package Rotation #1069
Closed
Key Package Rotation #1069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. This stack of pull requests is managed by Graphite. Learn more about stacking. |
neekolas
force-pushed
the
09-16-create_database_tables
branch
from
a8617a3
to
10f6d2d
Compare
neekolas
force-pushed
the
09-16-actually_perform_rotation
branch
5 times, most recently
from
7ddcb5f
to
8d772c7
Compare
neekolas
force-pushed
the
09-16-actually_perform_rotation
branch
from
8d772c7
to
b201e80
Compare
nplasterer
approved these changes
Sep 19, 2024
Merge activity
|
neekolas
changed the base branch from
09-16-create_database_tables
to
graphite-base/1069
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
More info
I wrap the rotation in a transaction so that we can ensure key packages only get deleted after a successful upload, while also ensuring that key packages cannot get uploaded without a corresponding
key_package_historyrecord being inserted. This has a performance impact, but is optimizing for correctness.Caveats
This will only work for new key packages. Existing key packages will be grandfathered in and never be deleted.