-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
consistent logging to enable better debugging #1096
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
requested review from
codabrink
and removed request for
a team and
codabrink
September 30, 2024 15:26
Your org has enabled the Graphite merge queue for merging into mainAdd the label “queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
insipx
force-pushed
the
insipx/remove-log
branch
from
September 30, 2024 16:14
eb5243b
to
79b8498
Compare
insipx
changed the title
Making logging more consistent to enable better debugging
consistent logging to enable better debugging
Sep 30, 2024
Thank you! |
codabrink
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes logging more consistent by only using the
tracing
crate wherever possible. thetracing
crate provides contextual tracing useful for debugging async code, but can also fallback to emittinglog
events if no subscriber is set.tracing-test
crate preferring a small custom closure to capture logs from tests insteadtokio
scurrent_thread
runtime. It can be made to work with a multi-thread environment, but not needed since its only used in a couple places so far. could make use oftracing-subscriber
reload handle with rustsLazyLock
global initializer to temporarily switch out a custom global subscriber that logs to a internal memory buffer only in the closure.traced-test
global subscriber inctor
, giving us the ability to filter logs during debuggingRUST_LOG=xmtp_mls::groups=DEBUG
to only get logs fromxmtp_mls/src/groups/mod.rs
tracing
also has useful adapters for debugging WebAssembly codeenv_logger
frommls_validation
service preferringtracing-subscriber
bindings_ffi
still uses thelog
crate. TheFfiLogger
trait doesn't fit well into thetracing::Subscriber
trait -- enabling tracing there could be a different issue/PR but for now the benefit would be small to switch it out