Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make member identifier the address instead of account_id #1172

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Make member identifier the address instead of account_id #1172

merged 4 commits into from
Oct 23, 2024

Conversation

neekolas
Copy link
Contributor

@neekolas neekolas commented Oct 22, 2024 •
edited
Loading

tl;dr

  • Makes the publicly visible address for a SCW the contract address and not the CAIP-10 address with the chain ID

Follow-ups

Bind SCW addresses to a single chain to avoid abuse of expired signers using 6492 signatures between chains.

@neekolas neekolas marked this pull request as ready for review October 22, 2024 23:41
@neekolas neekolas requested a review from a team as a code owner October 22, 2024 23:41
@neekolas neekolas merged commit 854307a into main Oct 23, 2024
7 checks passed
@neekolas neekolas deleted the nm/make-member-identifier-the-address branch October 23, 2024 15:52
insipx pushed a commit that referenced this pull request Oct 29, 2024
@neekolas @insipx
Make member identifier the address instead of account_id (#1172)
b6684a6 
* Make member identifier the address instead of account_id

* Lowercase address
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nplasterer nplasterer nplasterer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neekolas @nplasterer