Automatic sync - sync worker #1207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codabrink
commented
Nov 6, 2024
xmtp_mls/src/groups/mod.rs
Outdated
| @@ -228,6 +228,10 @@ pub struct MlsGroup<C> { | |||
| mutex: Arc<Mutex<()>>, | |||
| } | |||
|
|
|||
| // C is wrapped in an Arc, and so is the Mutex, so this is fine. | |||
| unsafe impl<C> Send for MlsGroup<C> {} | |||
| unsafe impl<C> Sync for MlsGroup<C> {} | |||
There was a problem hiding this comment.
@insipx This is so we can use this feature on wasm since the Client is neither Send nor Sync there. Everything in MlsGroup that isn't Send/Sync already is wrapped in an Arc, so this should be fine.
There was a problem hiding this comment.
If this is only for wasm, we should have it under #[cfg(target_arch = "wasm32")]
mchenani
reviewed
Nov 6, 2024
mchenani
reviewed
Nov 6, 2024
mchenani
reviewed
Nov 6, 2024
mchenani
reviewed
Nov 6, 2024
insipx
requested changes
Nov 6, 2024
xmtp_mls/src/groups/mod.rs
Outdated
| @@ -228,6 +228,10 @@ pub struct MlsGroup<C> { | |||
| mutex: Arc<Mutex<()>>, | |||
| } | |||
|
|
|||
| // C is wrapped in an Arc, and so is the Mutex, so this is fine. | |||
| unsafe impl<C> Send for MlsGroup<C> {} | |||
| unsafe impl<C> Sync for MlsGroup<C> {} | |||
There was a problem hiding this comment.
If this is only for wasm, we should have it under #[cfg(target_arch = "wasm32")]
|
I tested this in the android SDK and works like expected 🎉 |
codabrink
force-pushed
the
coda/sync-auto
branch
2 times, most recently
from
cd5688e
to
0a2fcc8
Compare
codabrink
force-pushed
the
coda/sync-auto
branch
from
4cce5fe
to
d7aaf40
Compare
insipx
reviewed
Nov 7, 2024
insipx
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.