Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group Chats Docs #650

Merged
merged 20 commits into from
Feb 20, 2024
Merged

Group Chats Docs #650

merged 20 commits into from
Feb 20, 2024

Conversation

humanagent
Copy link
Collaborator

@humanagent humanagent commented Feb 3, 2024 •
edited
Loading

@vercel Vercel
Copy link

vercel bot commented Feb 3, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
junk-range-possible ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 20, 2024 10:48pm

@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Feb 3, 2024 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4f6d6cb
Status: ✅  Deploy successful!
Preview URL: https://8e428842.website-9re.pages.dev
Branch Preview URL: https://groupchats.website-9re.pages.dev

View logs

@humanagent humanagent marked this pull request as ready for review February 5, 2024 11:55
@humanagent humanagent changed the title Group Chats Group Chats Docs Feb 5, 2024
scotboyd
scotboyd previously requested changes Feb 6, 2024
View reviewed changes
docs/build/groups.md Outdated Show resolved Hide resolved
docs/build/groups.md Show resolved Hide resolved
docs/build/groups.md Show resolved Hide resolved
This was referenced Feb 7, 2024
Closed
Closed
Closed
jhaaaa
jhaaaa reviewed Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@jhaaaa jhaaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for being so ahead of the curve on this, @fabriguespe! =)

I added a few style and copyedits in this commit. Let me know if you have any questions or concerns!

@humanagent humanagent marked this pull request as draft February 12, 2024 20:30
@humanagent
Copy link
Collaborator Author

humanagent commented Feb 18, 2024 •
edited
Loading

  • Added more snippets, including streams (Kotlin, RN and IOS)
  • Added call out for per-installation group chats (message history)
  • Added call out for generic conversations and messages features
  • Added syncGroups section
  • Added description for isActive
  • Added streamAll
  • Added references in messages, conversations and streams sections
  • Added sync() section

nplasterer
nplasterer reviewed Feb 20, 2024
View reviewed changes
docs/build/streams.md Show resolved Hide resolved
docs/build/streams.md Show resolved Hide resolved
docs/build/groups.md Outdated Show resolved Hide resolved
docs/build/groups.md Show resolved Hide resolved
docs/build/groups.md Outdated Show resolved Hide resolved
@humanagent humanagent dismissed scotboyd’s stale review February 20, 2024 14:44

Seems there was an issue similar to the other. I applied the changes! Thanks

@humanagent humanagent marked this pull request as ready for review February 20, 2024 22:42
@humanagent humanagent merged commit 16aecab into main Feb 20, 2024
4 checks passed
@humanagent humanagent deleted the groupchats branch February 20, 2024 22:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhaaaa jhaaaa jhaaaa left review comments

@nplasterer nplasterer nplasterer approved these changes

@scotboyd scotboyd scotboyd left review comments

@saulmc saulmc Awaiting requested review from saulmc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@humanagent @nplasterer @jhaaaa @scotboyd