feat: Frames Client #302
Merged
feat: Frames Client #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
April 1, 2024 12:15
Generate protos
Updates Protos Updated Read me for buf gen
Added frames client Need to do some verification first
Fixed handling Added test Fixed Lint
Fixed handling Added test Fixed Lint
nplasterer
reviewed
Apr 1, 2024
Fixed handling Added test Fixed Lint
neekolas
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
@alexrisch this looks fantastic! The fact that the E2E test works against a real frame gives me confidence this is doing all the signature stuff right.
nplasterer
approved these changes
Apr 3, 2024
Fixed handling Added test Fixed Lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction 📟
Issue: #298
Purpose ℹ️
Allow for native clients to utilize logic for Frames Client
Scope 🔭