Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction 📟
Sometimes groups were not getting streamed well in the RN SDK, especially when streaming messages at the same time
Purpose ℹ️
Make group streaming still work even if streaming all messages at the same time
Scope 🔭
We were using a single
StreamHolder
so when cancelling aTask
if something was streamed we were detecting it (with for instanceTask.isCancelled
and callingself.streamHolder.stream?.end()
on a stream which might not be the one we thought! Using an actor inside each streaming method to save & end the stream fixes it.Testing 🧪
I never managed to do a reproducible test directly in Swift. However I do have a failing test in the React Native repo:
can stream groups and messages
is failing on iOS on my side, but if I bring these Swift changes inside the XMTP Pod, it passes.See xmtp/xmtp-react-native#503