Dual Send 1to1 Conversations in V3 #414
Merged
+89
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
insipx
approved these changes
Nov 4, 2024
neekolas
approved these changes
Nov 4, 2024
mchenani
reviewed
Nov 4, 2024
Co-authored-by: Mojtaba Chenani <chenani@outlook.com>
nplasterer
added a commit
that referenced
this pull request
Nov 14, 2024
This reverts commit 1bb951d.
nplasterer
added a commit
that referenced
this pull request
Nov 14, 2024
nplasterer
added a commit
that referenced
this pull request
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has evolved a lot and I've ended on the simplest function to get a V2/V3 client pre creating conversations and dual sending messages.
This does not do any listing of V2 and V3 conversations in the same list which is where a lot of the complication arises with handling dual sent messages and requires a V2 database in libxmtp.